Upgrade glob to latest

[gyandeeps]

Mocha is using glob module version from 2013. I would be good if we can upgrade that to latest so that we can use a lot of globbing patterns with it.

If its ok, then I can send the PR.

[danielstjules]

We've previously experienced issues with upgrading dependencies: #1867 #1887 #1868

Aside from a bump, we'd want to verify compatibility with old versions of node/npm.

[gyandeeps]

What is our official nodejs support range?
If its too wide then this change might cause issue (but i have to try it).

[boneskull]

this is not possible as any glob newer than the one we currently have uses fuzzy version matching against minor versions (^) which precludes nodejs 0.8.

I imagine 0.8 will be dropped w/ next major, however.

closing for now

[boneskull]

(it doesn't actually preclude using 0.8; you can generally still upgrade npm, but some people cannot for various reasons)

[danez]

The problem on the other hand is that this old glob version depends on an old version of graceful-fs. And this one is using node apis which are getting removed in the next major. So either being backward compatible or forward :/
Probably the best way is to remove support for node < 4 in a new major, and if someone still wants to use unmaintained nodejs/iojs version, he can use older version of mocha.

From install:

npm WARN deprecated [email protected]: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.

[danielstjules]

Sounds like it won't get removed until v7: nodejs/node#5213 (comment) But I agree that we can look at breaking compatibility with the next major mocha release :) #2111 (comment)

[dead-claudia]

If you're testing against 0.8, graceful-fs was rewritten in 4.x to support 0.8 better, and it does test against that version in CI. And apparently, not much changed between 3.x and 4.x other than its monkey-patching-by-default behavior (which is likely to break something).

Most of the breakage you might encounter would probably be in node-glob, not graceful-fs, unless you unintentionally rely on graceful-fs' monkey-patching.

[danielstjules]

@isiahmeadows It's less about node compatibility, and more about npm. Releases newer than our current use a caret range (^) in version matching, which isn't supported in older versions of npm.

[dead-claudia]

Ok. What npm versions does this support?

Also, is it possible to use bundledDependencies? That could avoid the problem altogether, since npm@3 still supports 0.8.x, and this could be done at prepublish and in Travis/etc.

[boneskull]

@isiahmeadows >= v.1.2.30

bundledDependencies is something I hadn't thought of. Though I'm unsure of the implications. I'd be adverse to doing that in a minor release anyway...