Browser: improve 'bdd' import for bundlers #4769
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
History: #4746
Above PR proved to be too restrictive as it's no longer possible to do ES6 style
import { describe, it } from 'mocha'
while using bundlers.Description of the Change
browser-entry.js: push all
bdd
functions fromglobal
tomocha
.We have conflicts between
global.setup
(tdd
version ofbeforeEach
hook) andmocha.setup
(browser setup), and therefore we don't copy thetdd
functions tomocha
. Thetdd
interface has never/won't be available for ES6 style import.At the time of copying the
bdd
functions are undefined, nevertheless bundlers seem to rely on those lines. The exact logic remained unclear to me.Applicable issues
closes #4763