Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong error thrown while loading config files #4832

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Conversation

juergba
Copy link
Contributor

@juergba juergba commented Feb 16, 2022

Description

While loading a js/cjs config file, Mocha uses the cwd-realtive path and as a fallback the module-relative path.
Edge case: a config file is successfully found, but its loading fails due to a bad require. There is no sense in using the fallback for a second file search which results in an incorrect error message.

Description of the Change

We add a require.resolve() check which throws in case no config file can be found on the cwd-relative path. If it fails, retry again using the fallback path.

Applicable issues

closes #4781

@juergba juergba self-assigned this Feb 16, 2022
@juergba juergba added area: node.js command-line-or-Node.js-specific semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Feb 16, 2022
@juergba juergba added this to the next milestone Feb 16, 2022
@juergba juergba requested a review from a team February 16, 2022 08:18
@juergba juergba merged commit 86305cf into master Feb 17, 2022
@juergba juergba deleted the juergba/config branch February 17, 2022 17:01
@juergba juergba changed the title Fix loading of config files Fix: wrong error thrown while loading config files Feb 17, 2022
KuznetsovRoman pushed a commit to gemini-testing/mocha that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: node.js command-line-or-Node.js-specific semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocha throws UnparsableFileError instead of throwing the actual error when importing js/cjs
1 participant