Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Docs: Nightly Netlify deploys are failing #5098

Closed
3 tasks done
JoshuaKGoldberg opened this issue Feb 15, 2024 · 2 comments · Fixed by #5100
Closed
3 tasks done

📝 Docs: Nightly Netlify deploys are failing #5098

JoshuaKGoldberg opened this issue Feb 15, 2024 · 2 comments · Fixed by #5100
Assignees
Labels
area: documentation anything involving docs or mochajs.org area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer

Comments

@JoshuaKGoldberg
Copy link
Member

Documentation Request Checklist

Overview

Filing an issue for tracking & visibility: the site's nightly deploys are broken at the moment. We'll want to fix these:

7:19:05 PM: nps is executing `docs.postbuild` : buildProduction docs/_site/index.html --outroot docs/_dist --canonicalroot https://mochajs.org/ --optimizeimages --svgo --inlinehtmlimage 9400 --inlinehtmlscript 0 --asyncscripts && cp docs/_headers docs/_dist/_headers && node scripts/netlify-headers.js docs/_dist >> docs/_dist/_headers
7:19:05 PM: /bin/sh: 1: buildProduction: not found
7:19:05 PM: The script called "docs.postbuild" which runs "buildProduction docs/_site/index.html --outroot docs/_dist --canonicalroot https://mochajs.org/ --optimizeimages --svgo --inlinehtmlimage 9400 --inlinehtmlscript 0 --asyncscripts && cp docs/_headers docs/_dist/_headers && node scripts/netlify-headers.js docs/_dist >> docs/_dist/_headers" failed with exit code 127 https://github.com/sezna/nps/blob/master/other/ERRORS_AND_WARNINGS.md#failed-with-exit-code
7:19:05 PM: The script called "docs.production" which runs "nps docs && nps docs.postbuild" failed with exit code 127 https://github.com/sezna/nps/blob/master/other/ERRORS_AND_WARNINGS.md#failed-with-exit-code
7:19:05 PM: ​
7:19:05 PM: "build.command" failed                                        
7:19:05 PM: ────────────────────────────────────────────────────────────────
7:19:05 PM: ​
7:19:05 PM:   Error message
7:19:05 PM:   Command failed with exit code 127: npm start docs.production (https://ntl.fyi/exit-code-127)
7:19:05 PM: ​

Additional Info

@voxpelli started looking into it today. Partial progress: #5095.

@JoshuaKGoldberg JoshuaKGoldberg added type: bug a defect, confirmed by a maintainer status: accepting prs Mocha can use your help with this one! area: documentation anything involving docs or mochajs.org area: repository tooling concerning ease of contribution labels Feb 15, 2024
@JoshuaKGoldberg
Copy link
Member Author

I poked at this locally. It failed on my M1 Mac with Error executing gm: stream ended without emitting any data at first. Then after running brew install graphicsmagick, all was well. So that wasn't the real issue.

Netlify's complaint is buildProduction: not found. So it's some bin/scoping shenanigan where the bin/buildProduction from assetgraph-builder isn't being registered.

Band-aid / short-term fix: I bet we can replace buildProduction with node node_modules/assetgraph-builder/bin/buildProduction.

Better / longer-term fix: we'd previously talked about how we wanted to move off the old package-scripts / nps module. That might be nice, but would be a separate followup IMO.

@voxpelli
Copy link
Member

Yeah, the initial nps removal code is here, I need to break it out: #5042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants