Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular reference in Modelica.Media.Air.MoistAir.PsychrometricData #1679

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 6 comments
Assignees
Labels
bug Critical/severe issue L: Media Issue addresses Modelica.Media

Comments

@modelica-trac-importer
Copy link

Reported by stefanv on 11 Mar 2015 17:39 UTC
Modelica.Media.Air.MoistAir.PsychrometricData is a model containing the declaration,

package Medium = Modelica.Media.Air.MoistAir "Used medium package";

So, model PsychrometricData essentially contains a package that it's contained in. A tool that tries to naively walk the library will recurse forever.


Migrated-From: https://trac.modelica.org/Modelica/ticket/1679

@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Media Issue addresses Modelica.Media labels Jan 15, 2017
@modelica-trac-importer
Copy link
Author

Comment by stefanv on 11 Mar 2015 17:56 UTC
I believe this is a concrete case of the problem discussed in ticket #1458.

@modelica-trac-importer
Copy link
Author

Comment by hubertus on 11 Mar 2015 21:52 UTC
I see the problem. It is also strange that an example is just there in the middle of a package of functions without motivation. I did not do that. I am not sure what the best way to solve this is that complies with rules on minor releases. Do these rules hold if the model might violate the specification?

My simple solution would be to move this model to Media/Examples, which is where I think it belongs. Comments welcome, if there are no objections, I'll do that. And will change it in the 3.2.1 branch + trunk.

@modelica-trac-importer
Copy link
Author

Comment by hubertus on 22 Jun 2015 13:25 UTC
Fixed in trunk in 5fd4eb9

@modelica-trac-importer
Copy link
Author

Comment by hubertus on 22 Jun 2015 14:58 UTC
Fixed in the release branch in 8400060

@modelica-trac-importer
Copy link
Author

Changelog modified by hubertus on 22 Jun 2015 14:58 UTC
Circular Reference bug in Modelica.Media fixed

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 25 Jul 2015 15:04 UTC
It was forgotten to update the reference in the documentation to the new location: Fixed in e00b218 and 053ed51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Media Issue addresses Modelica.Media
Projects
None yet
Development

No branches or pull requests

2 participants