Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSL 4.1.0 Reference results for new models #4349

Open
maltelenz opened this issue Feb 29, 2024 · 9 comments
Open

MSL 4.1.0 Reference results for new models #4349

maltelenz opened this issue Feb 29, 2024 · 9 comments
Assignees
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined L: Resources Issue addresses Modelica/Resources (excl. C-Sources) P: high High priority issue ref-result Issue addresses the reference results
Milestone

Comments

@maltelenz
Copy link
Contributor

maltelenz commented Feb 29, 2024

MSL 4.1.0 comes with new example models compared to 4.0.0.

These need new reference results at https://github.com/modelica/MAP-LIB_ReferenceResults/tree/v4.1.0

List of new models:

Modelica.Blocks.Examples.DemonstrateContinuousSignalExtrema
Modelica.Blocks.Examples.DemonstrateSignalExtrema
Modelica.Blocks.Examples.DemoSignalCharacteristic
Modelica.Electrical.Analog.Examples.DemonstrateLightning
Modelica.Electrical.Analog.Examples.DemoPowerSupply
Modelica.Electrical.Analog.Examples.DemoPowerSupplyWithBuffer
Modelica.Electrical.Analog.Examples.Lines.CompareLineTrunks
Modelica.Electrical.Analog.Examples.Lines.CompareLosslessLines
Modelica.Electrical.Analog.Examples.Lines.LightningLosslessTransmissionLine
Modelica.Electrical.Analog.Examples.Lines.LightningSegmentedTransmissionLine
Modelica.Electrical.Analog.Examples.Lines.SmoothStep
Modelica.Electrical.Machines.Examples.DCMachines.DCPM_Drive
Modelica.Electrical.PowerConverters.Examples.DCDC.ChopperBuckBoost.ChopperBuckBoost_DutyCycle
Modelica.Electrical.PowerConverters.Examples.DCDC.ExampleTemplates.ChopperBuckBoost
Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_TrianglePWM_RL
Modelica.Electrical.QuasiStatic.SinglePhase.Examples.MultipleResonance
Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.InductionMachines.ComparisonPolyphase.IMC_DOL_CommonLeakage
Modelica.Magnetic.QuasiStatic.FundamentalWave.Examples.BasicMachines.InductionMachines.IMC_Inverter
Modelica.Magnetic.QuasiStatic.FundamentalWave.Examples.BasicMachines.SynchronousMachines.SMPM_FieldWeakening
Modelica.Mechanics.Rotational.Examples.CompareBrakingTorque
Modelica.Mechanics.Translational.Examples.CompareBrakingForce
ModelicaTest.Blocks.Exponentiation
ModelicaTest.Blocks.ZeroThresholds
ModelicaTest.Electrical.Machines.DCPM_CurrentControlled
ModelicaTest.Electrical.Machines.DCPM_SpeedControlled
ModelicaTest.Electrical.SingularTransformer
ModelicaTest.Fluid.TestComponents.Machines.TestLinearPower
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck2
ModelicaTest.MultiBody.Frames.QuaternionFromT
ModelicaTest.Tables.CombiTable1Ds.Test35
ModelicaTest.Tables.CombiTable1Dv.Test35
ModelicaTest.Tables.CombiTable2Ds.OneSidedDerivative2D
ModelicaTest.Tables.CombiTable2Ds.Test32
ModelicaTest.Tables.CombiTable2Ds.Test33
ModelicaTest.Tables.CombiTable2Dv.OneSidedDerivative2D
ModelicaTest.Tables.CombiTable2Dv.Test32
ModelicaTest.Tables.CombiTable2Dv.Test33
ModelicaTest.Tables.CombiTimeTable.Test89
@maltelenz maltelenz added the ref-result Issue addresses the reference results label Feb 29, 2024
@maltelenz maltelenz added this to the MSL4.1.0 milestone Feb 29, 2024
@beutlich
Copy link
Member

beutlich commented Feb 29, 2024

Sure. Already available at https://github.com/beutlich/MAP-LIB_ReferenceResults for patched v4.1.0-beta.1.

@beutlich
Copy link
Member

Sure. Already available at for patched v4.1.0-beta.1.

After spending some more time on #4343 I only noticed now that some of the simulation result is no longer reproducable. Not sure what I did then (beside the too much manual patching). In order not to use it I removed that fork for now. Sorry for the inconvenience.

@maltelenz
Copy link
Contributor Author

These models are missing a corresponding comparisonSignals.txt:

Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_TrianglePWM_RL
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck2

@beutlich
Copy link
Member

beutlich commented May 15, 2024

These models are missing a corresponding comparisonSignals.txt:

Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_TrianglePWM_RL
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck
ModelicaTest.Fluid.TestComponents.Pipes.DynamicPipeEnergyConservationCheck2

Confirmed, see #3679 for the first and #3959 for the other two. I actually wonder why I missed them for #4304. (Edit: Fixed by modelica-tools/msl-release@71b4d6a)

@AHaumer @casella This needs to be fixed before tagging a new release.

@beutlich beutlich added L: Resources Issue addresses Modelica/Resources (excl. C-Sources) L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined P: high High priority issue labels May 15, 2024
@casella
Copy link
Contributor

casella commented Jun 18, 2024

For the HBridge_TrianglePWM_RL results, I opened PR #4423 for @AHaumer to check.

Once accepted, it need to be back-ported to maint/4.1.0 before closing this ticket.

@casella
Copy link
Contributor

casella commented Jun 18, 2024

For the two new dynamic pipe check models, I opened PR #4425.

Once accepted, it need to be back-ported to maint/4.1.0 before closing this ticket.

@Esther-Devakirubai
Copy link
Contributor

Backported #4425 to maintenance by #4450

@casella
Copy link
Contributor

casella commented Aug 16, 2024

@Esther-Devakirubai can you also please backport #4423, adding the same reviewers as the original PR? Thanks!

@Esther-Devakirubai
Copy link
Contributor

@Esther-Devakirubai can you also please backport #4423, adding the same reviewers as the original PR? Thanks!

Done by #4454 . Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined L: Resources Issue addresses Modelica/Resources (excl. C-Sources) P: high High priority issue ref-result Issue addresses the reference results
Projects
None yet
Development

No branches or pull requests

5 participants