Implement choice between sawtooth and triangle reference signal in PowerConverters/DCDC/Control/SignalPWM #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
changed the title
beutlich
added
the
L: Electrical.PowerConverters
tobolar
reviewed
Jan 8, 2021
|
Omitting the full path to the option could lead to problems in some tools.
I'd prefer to keep it as it is.
Am Fr., 8. Jan. 2021 um 09:34 Uhr schrieb tobolar <[email protected]
…:
***@***.**** commented on this pull request.
------------------------------
In Modelica/Electrical/PowerConverters/DCDC/Control/SignalPWM.mo
<#3679 (comment)>
:
> parameter Boolean useConstantDutyCycle=true
"Enables constant duty cycle";
parameter Real constantDutyCycle=0 "Constant duty cycle"
annotation (Dialog(enable=useConstantDutyCycle));
parameter SI.Frequency f=1000 "Switching frequency";
+ parameter SingleReferenceType refType=Modelica.Electrical.PowerConverters.Types.SingleReferenceType.Sawtooth
Possibly ... refType=SingleReferenceType.Sawtooth ?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#3679 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUUUMNY7AKOWD7CISDAY2DSY27RNANCNFSM4UMHRBQQ>
.
|
…werConverters/DCDC/Control/SignalPWM
|
Please be aware that I rebased and force-pushed most of the open PR branches to update the CI which is now running through GitHub Actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backwards compatible enhancement:
For discrete and quasi-continuous control it is essential to sample the current at the right time instant during the pwm period to catch the mean current. Using triangle reference signal, it is easy to sample exactly in the middle of the pwm period.