-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement continuous version of SignalExtrema #4015
Conversation
@dietmarw @AHaumer We had a discussion in #3762 (comment) regarding whether or not the name shall contain
|
I think the proposal of @christiankral is the way to go. |
Co-authored-by: Hans Olsson <[email protected]>
Co-authored-by: Leo Gall <[email protected]>
Co-authored-by: Leo Gall <[email protected]>
Co-authored-by: Leo Gall <[email protected]>
@AHaumer @HansOlsson @MartinOtter do you have any objections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work.
My only concern is that it may cause unnecessary events in some cases - e.g., using an expsine-signal it seems we will continue to get events every cycle (due to u>=x and u<=x) even though we are far from an extremum.
I don't know exactly how to safely fix that (I can think of several possibilities - the problem is to ensure that they work), so I propose we delay such improvements until needed.
As already mentioned by @dietmarw in #3762 (comment), it might be worth to point again to the LastLib proof of concept how to calculate the signal extrema without events or derivatives. |
Co-authored-by: Thomas Beutlich <[email protected]>
Triggered by a discussion with @GallLeo and looking into #3762, I developed a continuous block to detect signal extrema, based on derivative. It works for non-differentiable inputs, too.