From 8a50c4a147de94b10bf098b5f540d22c43c76268 Mon Sep 17 00:00:00 2001 From: Dmitry Chigarev <62142979+dchigarev@users.noreply.github.com> Date: Tue, 9 Feb 2021 14:22:01 +0300 Subject: [PATCH] FIX-#2709: fixed typo in '_copartition' (#2710) Signed-off-by: Dmitry Chigarev --- modin/engines/base/frame/data.py | 4 ++-- modin/pandas/test/dataframe/test_indexing.py | 7 ++++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/modin/engines/base/frame/data.py b/modin/engines/base/frame/data.py index 5ddde663278..1e7c963de90 100644 --- a/modin/engines/base/frame/data.py +++ b/modin/engines/base/frame/data.py @@ -1810,7 +1810,7 @@ def get_axis_lengths(partitions, axis): or others_lengths[i] != base_lengths ) - # perform repartitioning and reindexing for `other` frames if needed + # perform repartitioning and reindexing for `other_frames` if needed reindexed_other_list = [None] * len(other_frames) for i in range(len(other_frames)): if do_repartition_others[i]: @@ -1819,7 +1819,7 @@ def get_axis_lengths(partitions, axis): i ]._frame_mgr_cls.map_axis_partitions( axis, - other[i]._partitions, + other_frames[i]._partitions, make_reindexer(do_repartition_others[i], base_frame_idx + 1 + i), lengths=base_lengths, ) diff --git a/modin/pandas/test/dataframe/test_indexing.py b/modin/pandas/test/dataframe/test_indexing.py index 6cd67b686aa..66b8aa44c1a 100644 --- a/modin/pandas/test/dataframe/test_indexing.py +++ b/modin/pandas/test/dataframe/test_indexing.py @@ -1243,6 +1243,8 @@ def test___setitem__(data): df_equals(modin_df, pandas_df) + +def test___setitem__partitions_aligning(): # from issue #2390 modin_df = pd.DataFrame({"a": [1, 2, 3]}) pandas_df = pandas.DataFrame({"a": [1, 2, 3]}) @@ -1259,12 +1261,15 @@ def test___setitem__(data): # Setting new column pd_df["b"] = pandas.Series(np.arange(4)) md_df["b"] = pd.Series(np.arange(4)) - df_equals(md_df, pd_df) + # Setting existing column pd_df["b"] = pandas.Series(np.arange(4)) md_df["b"] = pd.Series(np.arange(4)) + df_equals(md_df, pd_df) + pd_df["a"] = pandas.Series(np.arange(4)) + md_df["a"] = pd.Series(np.arange(4)) df_equals(md_df, pd_df)