-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select2 fails on project with existing select2 dependency #38
Comments
Beh, this dependency keeps biting us in the backside. We do not support select2 4.X. Right now, as a workaround, I suggest you subclass class MyAdminAdvancedFiltersMixin(AdminAdvancedFiltersMixin):
advanced_filter_form = MyAdvancedFilterForm Note: I mentioned the implication of updating select2 to >= 4 in this comment. |
@asfaltboy I'm not sure if I should be including duplicate v3 and v4 select2 client side dependencies at the same time. I'd rather attempt to fix the root problem in v4. Can you expand on what the problem is? Just to reiterate, I'm not sure the console error I'm seeing is related to what you're describing. |
I've done some work that fixed the syntax errors a while back but stashed it, see the The important thing is that we need to support custom values entered by user, which the current implementation doesn't allow by default. We would probably need to start using "tags"; as detailed in these SO answer: By the way, if you do decide to work on it, supporting both versions would be amazing! |
I'm trying to integrate advanced_filters into a project that already uses
django_select2
and hasSELECT2_CSS
andSELECT2_JS
settings set, but there are JS console errors thatselect2 is not a function
.The only difference I can see is that my select2 major version is 4.x.x while you expect 3.x.x.
Any thoughts?
The text was updated successfully, but these errors were encountered: