Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain reply #2872

Closed
Toberak1 opened this issue Nov 3, 2020 · 9 comments · Fixed by #2875
Closed

Plain reply #2872

Toberak1 opened this issue Nov 3, 2020 · 9 comments · Fixed by #2875
Labels

Comments

@Toberak1
Copy link

Toberak1 commented Nov 3, 2020

Hi
Can you please add ?preply (plain reply) command
It will reply to user without Embed (just plain text)
It will be useful when user is in mobile and cant copy content from embed

@Aloqeely
Copy link
Contributor

Aloqeely commented Nov 3, 2020

similar to #389, i think this is a highly suggested feature and should be added, but i'm not sure which way to implement this would be better (as a config or as a command)

@6days9weeks
Copy link
Contributor

I think it’d be good as a command instead of a config variable cause on the bot there’s areply,reply,freply so preply or whatever the devs add would be fine. I’m saying this as a user who uses modmail everyday and think a command would be better instead of config.

@Toberak1
Copy link
Author

Toberak1 commented Nov 3, 2020

I think it would be more configuration, I am used to this. Look
Screenshot_20201103-154951

@StephenDaDev
Copy link
Member

Both.

@fourjr
Copy link
Collaborator

fourjr commented Nov 4, 2020

Added to v3.6.3-dev1 which is still in development. Will be ready for public release soon.

fourjr added a commit that referenced this issue Nov 4, 2020
@fourjr fourjr closed this as completed Nov 4, 2020
@fourjr fourjr linked a pull request Nov 5, 2020 that will close this issue
@fourjr fourjr reopened this Nov 5, 2020
@fourjr fourjr added the staged Staged for next version label Nov 5, 2020
@RealCyGuy
Copy link
Member

Plain replies can't be deleted.
11/06/20 07:32:12 cogs.modmail[1318] - WARNING: Failed to delete message: DM message not found..

Checks for embeds:
https://github.com/kyb3r/modmail/blob/aba9b71a5568daeac3ea4448141704e4a589b178/core/thread.py#L525-537

@fourjr
Copy link
Collaborator

fourjr commented Nov 6, 2020

Plain messages are not able to be deleted due to how we internally find linked messages. This will be a limitation until post-database update (probably v4.0)

@lorenzo132
Copy link
Member

lorenzo132 commented Nov 8, 2020

Maybe also add the config to recieve plain replies from the users dming the bot, so in the thread ( #username-tag ) itll also show plain replies instead of embeds

@Toberak1
Copy link
Author

Toberak1 commented Nov 9, 2020

The idea of ​​my proposal is that the answers are possible to copy on mobile. Since the embed are not selectable as text to be able to copy and paste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants