Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOTTIE discord default sticker fails to retrieve #3119

Closed
lorenzo132 opened this issue Nov 20, 2021 · 5 comments
Closed

LOTTIE discord default sticker fails to retrieve #3119

lorenzo132 opened this issue Nov 20, 2021 · 5 comments
Labels
beta Feedback for beta testing bug This is a confirmed bug staged Staged for next version

Comments

@lorenzo132
Copy link
Member

lorenzo132 commented Nov 20, 2021

Bot Version

v3.11.0-dev1

How are you hosting Modmail?

Systemd

Error Logs

Screenshots

Additional Information

https://discord.com/channels/359577438101176320/911664310487486576/911668656033919038

@lorenzo132 lorenzo132 added the maybe: bug An unconfirmed bug label Nov 20, 2021
@fourjr fourjr changed the title dp2, animated sticker fails to retrieve LOTTIE discord default sticker fails to retrieve Nov 20, 2021
@fourjr fourjr added beta Feedback for beta testing bug This is a confirmed bug and removed maybe: bug An unconfirmed bug labels Nov 20, 2021
@fourjr
Copy link
Collaborator

fourjr commented Nov 20, 2021

can explore https://pypi.org/project/lottie/ to convert lottie -> gif

@fourjr
Copy link
Collaborator

fourjr commented Nov 21, 2021

Hey, after exploring how we can handle this... here are a couple options:

  1. Generate a GIF within Modmail (takes ~10 seconds)
  2. Pre-generate all GIFs and store it in Modmail/another external repo
  3. Only generate the first frame (takes ~0.08 seconds)

I'm personally in favour of the 3rd option, 10 seconds for sending a message would definitely take too long and pre-generating gifs require constant updating on our side. Thoughts?

Does anyone know how often discord updates these stickers?

@TheDiscordHistorian
Copy link

Hey, after exploring how we can handle this... here are a couple options:

  1. Generate a GIF within Modmail (takes ~10 seconds)
  2. Pre-generate all GIFs and store it in Modmail/another external repo
  3. Only generate the first frame (takes ~0.08 seconds)

I'm personally in favour of the 3rd option, 10 seconds for sending a message would definitely take too long and pre-generating gifs require constant updating on our side. Thoughts?

Does anyone know how often discord updates these stickers?

Users can also send custom stickers if they have nitro so maintaining would be difficult (Lottie is locked to partnered / verified servers), I agree with the 3rd option but just generate a png instead of a gif if it’s possible or 3rd as is works imo.

@fourjr
Copy link
Collaborator

fourjr commented Nov 21, 2021

If partnered servers can do LOTTIE as well, best to just generate a thumbnail.

@fourjr fourjr added the staged Staged for next version label Nov 21, 2021
fourjr added a commit that referenced this issue Nov 21, 2021
@lorenzo132
Copy link
Member Author

Hey, after exploring how we can handle this... here are a couple options:

  1. Generate a GIF within Modmail (takes ~10 seconds)
  2. Pre-generate all GIFs and store it in Modmail/another external repo
  3. Only generate the first frame (takes ~0.08 seconds)

I'm personally in favour of the 3rd option, 10 seconds for sending a message would definitely take too long and pre-generating gifs require constant updating on our side. Thoughts?

Does anyone know how often discord updates these stickers?

would be nice to make it a config option, to either have it as opt 1 or 3

jcharlesl added a commit to jcharlesl/modmail that referenced this issue May 2, 2022
…s. Relevant to issue modmail-dev#3119, LOTTIE discord default sticker fails to retrieve.
@fourjr fourjr closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Feedback for beta testing bug This is a confirmed bug staged Staged for next version
Projects
None yet
Development

No branches or pull requests

3 participants