Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website-new): add nx guides #3092

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 20, 2024

Description

Add Nx Practice Sections to the React + Angular Framework sections.

Screenshots of the Changes

  1. Add Nx to Ecosystem dropdown
image
  1. Add Nx Angular Practice Guide
image image
  1. Add Nx React Practice Guide
image image
  1. Add Nx Callout on Quick Start Guide
image

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Oct 20, 2024

⚠️ No Changeset found

Latest commit: a4030c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit a4030c5
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/671509526712dd0008fa303b
😎 Deploy Preview https://deploy-preview-3092--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zackarychapple
Copy link
Collaborator

Thank you for adding the Nx documentation. I believe we need to spend some time to redesign our "ecosystem" to not be a dropdown but a page that describes our overall ecosystem philosophy and partners.

@zackarychapple zackarychapple merged commit 4ac0fbc into module-federation:main Oct 21, 2024
15 checks passed
@Coly010 Coly010 deleted the docs/add-nx branch October 21, 2024 14:13
@Coly010
Copy link
Contributor Author

Coly010 commented Oct 21, 2024

Thank you for adding the Nx documentation. I believe we need to spend some time to redesign our "ecosystem" to not be a dropdown but a page that describes our overall ecosystem philosophy and partners.

I agree. As well as highlighting integrations between the ecosystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants