Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag names don't work with commas #132

Open
jmacdonald-spectacle opened this issue Feb 25, 2021 · 4 comments
Open

Tag names don't work with commas #132

jmacdonald-spectacle opened this issue Feb 25, 2021 · 4 comments

Comments

@jmacdonald-spectacle
Copy link

If I add a tag like 'Peace, Love & Understanding,' the tag won't save with the resource.

Removing the comma will let the tag save, but if commas in tag names aren't allowed they should be restricted from being added. (or, at least, documented)

Tagger version : 1.12.0
MODX version: 2.8.1

@jmacdonald-spectacle
Copy link
Author

I added the tag in the Tagger Tags tab. If I try to add it in the resource, I'll get two tags.

@pbowyer
Copy link

pbowyer commented Aug 2, 2023

I have the same problem.
Tagger 1.12.0-pl
MODX 2.8.4-pl

@matdave
Copy link
Contributor

matdave commented Aug 4, 2023

@pbowyer This has been addressed with Tag Labels

@SnowCreative
Copy link

SnowCreative commented Sep 26, 2023

@pbowyer This has been addressed with Tag Labels

Can you describe what you mean exactly by tag labels fixing the issue? I don't see how that is working.

If I have tag with a comma, like the chemical name "1,3-butadiene", I tried entering that for the label and "1,3-butadiene" for the tag. When I try to add that tag to a resource by typing in the field (start typing "1,3" and the popup then lists the tag), it gets entered in the field as "1, 1,3-butadiene,", creating two tags, one of which is just "1". If I enter "1,3-butadiene" for both the tag and label, then I can insert the tag properly, but "1,3-butadiene" shows up as the tag name in the field until I hit the 'Assign" button; then the tag goes in the list below the field with the correct formatting (showing a comma).

I could make the actual tag "1-3-butadiene", but that would look wrong to scientists using the site, even though it only appears briefly in the field before clicking Assign. And, no matter what I make the actual tag, for any group that has a large number of tags, typing needs be enabled for easy selection, and so someone will type in "1,3" (since the popup doesn't show up until at least 3 characters are entered), and when they select "1,3-butadiene" from the popup list, the field will only replace the "3" with the actual tag; the "1" will get entered as a separate tag.

Also, for any group that allows adding tags by typing them into the resource Tag field, if someone tries to add a tag that has a comma in it, that will create two tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants