Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use a comma within the tagger name #144

Open
bennyb opened this issue Jul 8, 2024 · 3 comments
Open

Can't use a comma within the tagger name #144

bennyb opened this issue Jul 8, 2024 · 3 comments

Comments

@bennyb
Copy link

bennyb commented Jul 8, 2024

It seems you can't use a comma in the tagger name, if for example you create a tag called
Tagger: 2.0.0-pl
MODX: 3.0.5

one, two & three.

Can can see this fine within the tagger select dropdown while editing a resource, but if you assign it then everything after the comma is ignored. Using the above example it would try and assign a tag called one. If you save and then refresh nothing is actually saved.

There is the label field which could work if this can then be used within the resource tagger dropdown and selected tags as you have to rename the name field for the tag which can mean it doesn't make sense to the user without the comma.

Also if that field can't have a comma than this should get stripped out when creating the tag to avoid users adding this in by mistake.

@matdave
Copy link
Contributor

matdave commented Jul 23, 2024

This has been the case since inception. However you can add a "Label" to the tag with a comma

@bennyb
Copy link
Author

bennyb commented Jul 24, 2024

This has been the case since inception. However you can add a "Label" to the tag with a comma

Yeah I see the label, issue with that is there's no way of displaying that to a user who's doing the tagging. So without a comma the tag name can make no sense. Obviously displays ok when viewed on Frontend but be good to be able to specify to use label on the tagger tab on the resource.

Also be good if tagger could strip the comma from the name as no warning so users who can add tags themselves will get confused as to why their tags can't be used on a resource as they appear as normal.

@matdave
Copy link
Contributor

matdave commented Jul 25, 2024

You can intentionally add commas to create multiple tags. This is why we don't allow commas in tag names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants