Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with PHP 8 #76

Open
MaticSulc opened this issue Mar 12, 2023 · 1 comment
Open

Compatibility with PHP 8 #76

MaticSulc opened this issue Mar 12, 2023 · 1 comment

Comments

@MaticSulc
Copy link

MaticSulc commented Mar 12, 2023 •
edited
Loading

I've toggled the setting phpthumbof.check_mod_time, latest pThumb version drops an error:

Fatal error: Uncaught TypeError: round(): Argument #1 ($num) must be of type int|float, string given in /home/domain/domain.tld/core/vendor/james-heinrich/phpthumb/phpthumb.class.php:1990 Stack trace: #0

I can reproduce this on PHP 8 and higher. Can we expect a fix for this anytime soon?
@travisbotello
Copy link

Bumping this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@travisbotello @MaticSulc