Migrate to win32 5.5.4 #780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Aug 28, 2024
| @@ -3,8 +3,8 @@ description: Demonstrates how to use the flutter_secure_storage_windows plugin. | |||
| publish_to: 'none' | |||
|
|
|||
| environment: | |||
| sdk: '>=2.12.0 <3.0.0' | |||
| flutter: ">=2.0.0" | |||
| sdk: '>=3.4.0 <4.0.0' | |||
There was a problem hiding this comment.
This aligns the windows example with the windows implementation.
navaronbracke
commented
Aug 28, 2024
| // TODO: New member requires win32 ^5.4.0 | ||
| // ignore: deprecated_member_use | ||
| ERROR_OUTOFMEMORY, | ||
| WIN32_ERROR.ERROR_OUTOFMEMORY, |
There was a problem hiding this comment.
These TODO's can now be addressed.
navaronbracke
commented
Aug 28, 2024
| @@ -4,8 +4,8 @@ repository: https://github.com/mogol/flutter_secure_storage | |||
| version: 3.1.2 | |||
|
|
|||
| environment: | |||
| sdk: '>=2.12.0 <4.0.0' | |||
| flutter: ">=2.0.0" | |||
| sdk: '>=3.4.0 <4.0.0' | |||
There was a problem hiding this comment.
Since the last two Flutter releases (3.22.0 and 3.24.0) are way ahead of the current version range, I opted into updating it here, to match the Dart 3.4.0 requirement for win32.
|
@mogol If you could take a look that would be very appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
flutter_secure_storage_windowsto support Dart 3.4.0 / Flutter 3.22.0 (and by extension also Dart 3.5.0 / Flutter 3.24.0)I did not update the version of
flutter_secure_storage_windows, as changing the supported Flutter version could possibly be seen as a breaking change. That said, if we use the new version constraint for the latest Flutter stable across all offlutter_secure_storage, you could also start cleaning up the deprecated usages ofdescribeEnum()(which are the only ignores in this plugin's Dart code AFAIK)Fixes #779