Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: required props #145

Merged
merged 2 commits into from
Sep 30, 2022
Merged

fix: required props #145

merged 2 commits into from
Sep 30, 2022

Conversation

kirgene
Copy link
Contributor

@kirgene kirgene commented Sep 30, 2022

  • make transactionId optional for bulkTransactionIndividualTransferResult type
  • make expiration required for bulkQuoteResponse type
  • fix type names

@kirgene
fix: required props
af75fb3 
* make `transactionId` optional for `bulkTransactionIndividualTransferResult` type
* make `expiration` required for `bulkQuoteResponse` type
* fix type names
mdebarros
mdebarros approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kirgene kirgene merged commit d615f4a into master Sep 30, 2022
@kirgene kirgene deleted the fix/types branch September 30, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@kleyow kleyow Awaiting requested review from kleyow

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@vijayg10 vijayg10 Awaiting requested review from vijayg10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirgene @mdebarros