feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of TransferId - removed transactionId as required from bulkTransaction Individual Transfer Accept PUT callback (for both accept parties & quotes) - rebuild outbound API swagger
mdebarros
requested review from
kleyow,
elnyry-sam-k,
lewisdaly,
vijayg10 and
kirgene
as code owners
36 tasks
PaulGregoryBaker
previously approved these changes
Nov 11, 2022
mdebarros
added a commit
to mojaloop/sdk-scheme-adapter
that referenced
this pull request
Nov 11, 2022
… instead of TransferId feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId - mojaloop/project#3018 - bumped api-snippets to v17.0.0-snapshot.0 --> TODO: Upgrade this to final version once PR (mojaloop/api-snippets#148) has been merged - updated applicable events to include the transferId - updated aggregate handlers to correctly map the transferId instead of the transactionId - updated TTK API definitions for SDK Outbound API specifications (copied from API-Snippets) - updated TTK Test Case "bulk_happy_path_dynamic" to correctly use the transferId instead of the transactionId chore: improvements to docker-compose for debugging - added "start:debug" to each of the modules to start with debugging enabled - updated docker-compose to use the "start:debug" command to be able to attach and debug issues
vijayg10
previously approved these changes
Nov 11, 2022
mdebarros
dismissed stale reviews from vijayg10 and PaulGregoryBaker
via
fdd3ad0
…tional for bulkTransactions" This reverts commit 76ea4b7.
- Removed transactionId, bulkHomeTransactionId & homeTransactionId from bulkTransaction Callbacks for Accept Quotes & Parties - Made transferId required on callback to FSP Backend
kleyow
approved these changes
Nov 11, 2022
mdebarros
deleted the
feat/#3018-TransactionId-is-being-used-instead-of-TransferId
branch
kleyow
added a commit
to mojaloop/sdk-scheme-adapter
that referenced
this pull request
Nov 12, 2022
… instead of TransferId (#422) * feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId - mojaloop/project#3018 - bumped api-snippets to v17.0.0-snapshot.0 --> TODO: Upgrade this to final version once PR (mojaloop/api-snippets#148) has been merged - updated applicable events to include the transferId - updated aggregate handlers to correctly map the transferId instead of the transactionId - updated TTK API definitions for SDK Outbound API specifications (copied from API-Snippets) - updated TTK Test Case "bulk_happy_path_dynamic" to correctly use the transferId instead of the transactionId chore: improvements to docker-compose for debugging - added "start:debug" to each of the modules to start with debugging enabled - updated docker-compose to use the "start:debug" command to be able to attach and debug issues * chore(snapshot): 21.4.0-snapshot.0 * docs: cleanup on readme * fix: for outbound-command-handler integration tests * chore(snapshot): 21.4.0-snapshot.1 * updated api-snippets * chore(snapshot): 21.4.0-snapshot.2 * chore: made updates for api-snippets 17.0.0-snapshot.2 changes - updated mappings based on the api-snippets changes - updated api_specs for fun-test TTK api definitions * updates to main readme about redis-insights and added todo on docker-compose * chore(snapshot): 21.4.0-snapshot.3 * updated api-snippets to final v17.0.0 version * chore(snapshot): 21.4.0-snapshot.4 * test: updated bulk_happy_path_dynamic to align to api-snippets v17.0.0 release * removed bulkHomeTransactionId from PUT ACCEPT /bulkTransaction callbacks from bulk_happy_path_dynamic func test * fix for integration tests * chore(snapshot): 21.4.0-snapshot.5 * chore: yarn and merge * chore: remove ncu * chore: id * chore(snapshot): 21.4.0-snapshot.0 Co-authored-by: Kevin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId - mojaloop/project#3018
BREAKING CHANGE: transferId is now required on bulkTransaction Individual Transfer Accept PUT callback (for both accept parties & quotes), and bulkHomeTransaction, homeTransaction, and transaction Id' have been removed.