Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a loading indicator to the edit modal #54

Open
ryanmortier opened this issue Aug 24, 2024 · 1 comment
Open

Adding a loading indicator to the edit modal #54

ryanmortier opened this issue Aug 24, 2024 · 1 comment
Labels
bug Something isn't working v3 Planned for v3

Comments

@ryanmortier
Copy link
Contributor

What happened?

I'm trying to add a loading indicator to the edit modal submit button but running into issues. Wondering if you know how to fix this?

I added a wire:target attribute to the edit modal submit button but as you can see in the screenshot below, it's not aligned to the cancel button for some reason when the indicator is shown. Is this an issue with the view or am I adding the indicator wrong?

<x-filament::button type="submit" wire:target="editModalFormSubmitted">
    {{ $this->getEditModalSaveButtonLabel() }}
</x-filament::button>

CleanShot 2024-08-24 at 18 05 59

How to reproduce the bug

Add wire:target to submit button on edit modal view.

Package Version

2.8

PHP Version

8.2

Laravel Version

11.21

Which operating systems does with happen with?

macOS

Which browsers does with happen with?

Chrome

Notes

No response

@ryanmortier ryanmortier added the bug Something isn't working label Aug 24, 2024
@mokhosh
Copy link
Owner

mokhosh commented Sep 1, 2024

I can confirm this issue is there. I will hopefully fix this for v3.

Meanwhile you can wrap the two buttons in a div like this:

<div class="flex items-end gap-2">
...
</div>

@mokhosh mokhosh added the v3 Planned for v3 label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v3 Planned for v3
Projects
None yet
Development

No branches or pull requests

2 participants