Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The library fails to handle a missing script #20

Closed
bsideup opened this issue Jun 25, 2018 · 3 comments · Fixed by #21
Closed

The library fails to handle a missing script #20

bsideup opened this issue Jun 25, 2018 · 3 comments · Fixed by #21

Comments

@bsideup
Copy link
Contributor

bsideup commented Jun 25, 2018

Hi!

We use RateLimitJ with AWS ElastiCache. Today we had an outage because AWS ElastiCache performed a maintenance and for some reason (we're going to check with AWS guys as well) the Lua scripts disappeared.
We started getting this error:

NOSCRIPT No matching script. Please use EVAL.

Would be great if the library will handle it gracefully and re-upload the scripts if they're missing.
I assume this is easy to test by uploading the scripts, running FLUSHALL and then attempting to apply the rate limiting.
Shameless plug: you can use http://github.com/testcontainers/testcontainers-java to test that ☺️

@ofirnk
Copy link
Contributor

ofirnk commented Jun 25, 2018

From a neighbouring project ;)
gresrun/jesque#143

@mokies
Copy link
Owner

mokies commented Aug 12, 2018

Thanks for your patience this is now fixed fff2883 and will be included in the next release.

@mokies mokies closed this as completed Aug 12, 2018
@mokies
Copy link
Owner

mokies commented Aug 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants