Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SETTINGS frame in framer.js #238

Open
castpuz opened this issue Mar 8, 2017 · 0 comments
Open

SETTINGS frame in framer.js #238

castpuz opened this issue Mar 8, 2017 · 0 comments

Comments

@castpuz
Copy link

castpuz commented Mar 8, 2017 •
edited
Loading

In Deserializer.SETTINGS,

  if (buffer.length % 6 !== 0) { 
    return 'PROTOCOL_ERROR';
  }

BUT

rfc7540 says "A SETTINGS frame with a length other than a multiple of 6 octets MUST be treated as a connection error of type FRAME_SIZE_ERROR."

So, Isn't return 'FRAME_SIZE_ERROR' correct?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@castpuz