Don't publish tests to npm #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When publishing to npm, it's unnecessary to publish all 19 MB of test files.
mattjohnsonpint
added a commit
that referenced
this pull request
Nov 25, 2013
Don't publish tests to npm
|
Thanks! |
|
No problems. Is there a new release planned somewhere soon btw, so this actually ends up on npmjs.org? |
|
There will be a new release of moment-timezone soon, yes. Sometime in the next few days. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing to npm, it's unnecessary to publish all 19 MB of test files.
Sure, tests are nice, but when installing a library I don't expect to run all tests on it. If I discover a bug in it, I clone it from the repo, and run the tests there.
Having to download almost 20 megs of stuff I will never use seems a bit excessive.
Comparatively, the footprint in my node_modules for express is around 640k.