Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile to run net461 only if the windows os is detected #471

Open
malandis opened this issue Sep 1, 2023 · 0 comments
Open

Update Makefile to run net461 only if the windows os is detected #471

malandis opened this issue Sep 1, 2023 · 0 comments

Comments

@malandis
Copy link
Contributor

malandis commented Sep 1, 2023

Currently our Makefile has different targets for testing against .NET 6.0 + .NET Framework 4.61 vs .NET 6.0 only vs .NET Framework 4.61. The latter tests, .NET Framework 4.61, only work on Windows. We can collapse makefile targets into a single target that only tests against .NET Framework 4.61. if Windows is detected, else .NET 6.0 only.

Also consider updating the test runner to exclude .NET Framework 4.61 tests based on the host OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant