feat: remove legacy sdk and related artifacts #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the imminent release of the new SDK, we remove the legacy SDK from the code base, all related uitlities, tests, and examples.
This is used by the CLI to log in via browser. In the future we can add this directly in the CLI library as this is not related to the other client libraries.
malandis
commented
May 6, 2024
| } | ||
| } | ||
|
|
||
| /// Initiate a login workflow. |
There was a problem hiding this comment.
I feel this code belongs in the CLI as opposed to here. The CLI is the sole consumer of this. If we believe that it has broader utility and want to support it with our 1.0 guarantees I can add it back here.
cc @cprice404
malandis
commented
May 6, 2024
| /// # let get_response = Get::Hit { value: momento::response::GetValue::new(vec![]) }; | ||
| /// # let get_response = Get::Hit { value: GetValue::new(vec![]) }; |
There was a problem hiding this comment.
Many of the docstrings in this file were still referencing the legacy SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the imminent release of the new SDK, we remove the legacy SDK
from the code base, all related uitlities, tests, and examples.