Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve resource exhausted message #398

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Nov 5, 2024

Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/1040

When a RESOURCE_EXHAUSTED error is received, we now parse the err metadata in order to report the cause in the message wrapper. If the metadata is not available, we try to use string matching on the error details.

@anitarua anitarua marked this pull request as ready for review November 5, 2024 23:21
@anitarua anitarua requested a review from a team November 5, 2024 23:26
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers but some style ideas 👍

sdk/src/errors.rs Outdated Show resolved Hide resolved
sdk/src/errors.rs Outdated Show resolved Hide resolved
malandis
malandis previously approved these changes Nov 8, 2024
@anitarua anitarua merged commit 84a0cbf into main Nov 8, 2024
4 checks passed
@anitarua anitarua deleted the resource-exhausted branch November 8, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants