Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: when the prop title is undefined do not draw the monday style attention box component title container #287

Merged
merged 4 commits into from
Oct 24, 2021
Merged

Feature: when the prop title is undefined do not draw the monday style attention box component title container #287

merged 4 commits into from
Oct 24, 2021

Conversation

pedaars
Copy link
Contributor

@pedaars pedaars commented Oct 20, 2021

Description: Feature: Attention box - when the prop "title" is undefined do not draw the "monday-style-attention-box-component__title-container"

Updating existing component

Basic

  • PR has description
  • Changes to the component are backward compatible (including selectors structure). If not - add to the title of the PR "BREAKABLE_CHANGE""
  • All changes to the component are reflected in the ReadMe
  • If component is old and was not compliant with the latest guidelines - it was fixed (optional)

Style

Storybook

  • All the changes to the component should be reflected in the Storybook.
  • [] Component passed Accessibility Plugin checks

Tests

  • All current tests are passing
  • New functionality is covered with tests
  • Tests are compliant with TESTING_README.md instructions

title prop is not empty
image

title prop is empty or undefined
image

Aaron Pedwell and others added 3 commits October 15, 2021 15:40
…aw the "monday-style-attention-box-component__title-container
…o_not_draw_the_monday-style-attention-box-component__title-container
…aw the "monday-style-attention-box-component__title-container"
@pedaars pedaars changed the title Pedaars/when the prop title is undefined do not draw the monday style attention box component title container Feature: when the prop title is undefined do not draw the monday style attention box component title container Oct 20, 2021
@hadasfa hadasfa self-requested a review October 21, 2021 11:52
…o_not_draw_the_monday-style-attention-box-component__title-container
@MosheZemah MosheZemah merged commit 950f236 into mondaycom:master Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants