Feat/orr/custom icon preproccessor #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahariko
approved these changes
Oct 24, 2021
| import PropTypes from "prop-types"; | ||
| import cx from "classnames"; | ||
| import SVG from "react-inlinesvg"; | ||
| import "./CustomSvgIcon.scss"; | ||
| import useIconScreenReaderAccessProps from "../../hooks/useIconScreenReaderAccessProps"; | ||
|
|
||
| const CustomSvgIcon = ({ className, src, onClick, clickable, ariaLabel, ariaHidden, ...props }) => { | ||
| function modifySvgCode(svg, color = "currentColor") { | ||
| return svg.replace(/fill=".*?"/g, `fill="${color}"`); |
There was a problem hiding this comment.
Do we want to replace stroke as well?
| */ | ||
| useCurrentColor: PropTypes.bool, | ||
| /** | ||
| * If you want to override to coloring of currentColor |
There was a problem hiding this comment.
Suggested change
| * If you want to override to coloring of currentColor | |
| * If you want to override the icon's color |
| ariaHidden: PropTypes.bool | ||
| ariaHidden: PropTypes.bool, | ||
| /** | ||
| * when using svg from src (Icon.type.SRC) this boolean will transform the "fill" property to "currentColor" |
There was a problem hiding this comment.
Suggested change
| * when using svg from src (Icon.type.SRC) this boolean will transform the "fill" property to "currentColor" | |
| * when using svg from src (`Icon.type.SRC`) this boolean will make the icon inherit its color from text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go over this checklist before submitting your Pull Request
Description: ADD YOUR PR DESCRIPTION HERE
STEP 1: Fulfill the description of the PR above
STEP 2: Select one of 2 main scenarios of adding the new component or editing the existing one
STEP 3: Delete checklist which you don't need
STEP 4: Go over the checklist. All checkboxes should be marked
STEP 5: Delete this instruction
STEP 6: Happy code review and merge!
Adding new component
Basic
Style
Storybook
Tests
Updating existing component
Basic
Style
Storybook
Tests