-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clean lint erros and remove not needed component #304
Conversation
onClick, | ||
enableTextSelection, | ||
ariaLabel, | ||
onMouseDown, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it problematic that we don't use this function at all while using keyboard?
ariaLabel, | ||
onMouseDown, | ||
ariaHidden, | ||
tabIndex, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ariaHidden is true it could be nice that the default value of the tab index will be -1 (because we don't want to allow focus on hidden item and clickable should do all the default a11y settings for the developer)
@@ -45,7 +45,8 @@ | |||
{ | |||
"required": { | |||
"some": ["nesting", "id"] | |||
} | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth maybe changing the rules you fixed into error from warn?
Go over this checklist before submitting your Pull Request
Description: ADD YOUR PR DESCRIPTION HERE
STEP 1: Fulfill the description of the PR above
STEP 2: Select one of 2 main scenarios of adding the new component or editing the existing one
STEP 3: Delete checklist which you don't need
STEP 4: Go over the checklist. All checkboxes should be marked
STEP 5: Delete this instruction
STEP 6: Happy code review and merge!
Adding new component
Basic
Style
Storybook
Tests
Updating existing component
Basic
Style
Storybook
Tests