Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amitha/feature/combobox-no-results #314

Merged
merged 1 commit into from
Nov 1, 2021
Merged

amitha/feature/combobox-no-results #314

merged 1 commit into from
Nov 1, 2021

Conversation

amit-hanoch
Copy link
Contributor

@amit-hanoch amit-hanoch commented Oct 31, 2021 •
edited
Loading

Add renderer for empty state so you can use something other than the default

Updating existing component

Basic

  • PR has description
  • Changes to the component are backward compatible (including selectors structure). If not - add to the title of the PR "BREAKABLE_CHANGE""
  • All changes to the component are reflected in the ReadMe
  • If component is old and was not compliant with the latest guidelines - it was fixed (optional)

Style

Storybook

  • All the changes to the component should be reflected in the Storybook.
  • Component passed Accessibility Plugin checks

Tests

  • All current tests are passing
  • New functionality is covered with tests
  • Tests are compliant with TESTING_README.md instructions

@orrgottlieb orrgottlieb merged commit d07555c into master Nov 1, 2021
@orrgottlieb orrgottlieb deleted the amitha/feature/combobox-no-results branch November 1, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orrgottlieb orrgottlieb Awaiting requested review from orrgottlieb

@hadasfa hadasfa Awaiting requested review from hadasfa

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amit-hanoch @orrgottlieb