-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tooltip content option to combobox item #321
Conversation
id: "4", | ||
label: "disabled with disable reason", | ||
disabled: true, | ||
disableReason: "reason for disabled", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change tooltip prop to tooltipContent
@@ -90,10 +91,16 @@ const ComboboxOption = ({ | |||
}, | |||
[onOptionClick, index, option] | |||
); | |||
let tooltipContent; | |||
if (disabled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the logic to the following: if there is a tooltip content display it as tooltip, else take the tooltip content from "isOptionOverflowing ? label : null"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I wrote few notes
9da0628
to
38620d6
Compare
Go over this checklist before submitting your Pull Request
Description: ADD YOUR PR DESCRIPTION HERE
STEP 1: Fulfill the description of the PR above
STEP 2: Select one of 2 main scenarios of adding the new component or editing the existing one
STEP 3: Delete checklist which you don't need
STEP 4: Go over the checklist. All checkboxes should be marked
STEP 5: Delete this instruction
STEP 6: Happy code review and merge!
Adding new component
Basic
Style
Storybook
Tests
Updating existing component
Basic
Style
Storybook
Tests