amitha/feature/dialog-is-reference-hidden #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orrgottlieb
approved these changes
Nov 4, 2021
MosheZemah
reviewed
Nov 7, 2021
| return ( | ||
| <DialogContent | ||
| isReferenceHidden={hideWhenReferenceHidden && isReferenceHidden} |
There was a problem hiding this comment.
maybe send isReferenceHidden as is
and also pass the other prop (hideWhenReferenceHidden) to the dialogContent component?
| @@ -346,12 +348,19 @@ export default class Dialog extends PureComponent { | |||
| ...modifiers | |||
| ]} | |||
| > | |||
| {({ placement, style, ref, arrowProps }) => { | |||
| {({ placement, style, ref, arrowProps, isReferenceHidden }) => { | |||
There was a problem hiding this comment.
@orrgottlieb are we ok with sending new objects/arrays every time to the popper component?
There was a problem hiding this comment.
it is the render props methodology, it is a render function. isReferenceHidden is a boolean @MosheZemah
There was a problem hiding this comment.
I meant the code above that line (that wasn't changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide dialog when reference is hidden
Updating existing component
Basic
Style
Storybook
Tests