Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox: fix the space between the search box to the first option #332

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Combobox: fix the space between the search box to the first option #332

merged 2 commits into from
Nov 15, 2021

Conversation

amit-hanoch
Copy link
Contributor

@amit-hanoch amit-hanoch commented Nov 14, 2021 •
edited
Loading

image

The first item was close to the search. added spacing to it.

Updating existing component

Basic

  • PR has description
  • Changes to the component are backward compatible (including selectors structure). If not - add to the title of the PR "BREAKABLE_CHANGE""
  • All changes to the component are reflected in the ReadMe
  • If component is old and was not compliant with the latest guidelines - it was fixed (optional)

Style

Storybook

  • All the changes to the component should be reflected in the Storybook.
  • Component passed Accessibility Plugin checks

Tests

  • All current tests are passing
  • New functionality is covered with tests
  • Tests are compliant with TESTING_README.md instructions

@amit-hanoch amit-hanoch changed the title spacing for the first option amitha/fix/combobox-first-option-spacing Nov 14, 2021
@hadasfa hadasfa self-requested a review November 15, 2021 08:03
@hadasfa hadasfa changed the title amitha/fix/combobox-first-option-spacing Combobox: fix space between the search box to the first option Nov 15, 2021
@hadasfa hadasfa changed the title Combobox: fix space between the search box to the first option Combobox: fix the space between the search box to the first option Nov 15, 2021
@hadasfa hadasfa merged commit 23e5d5a into master Nov 15, 2021
@hadasfa hadasfa deleted the amitha/fix/combobox-first-option-spacing branch November 15, 2021 08:11
@ravivzomer ravivzomer mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadasfa hadasfa hadasfa approved these changes

@orrgottlieb orrgottlieb Awaiting requested review from orrgottlieb

@MosheZemah MosheZemah Awaiting requested review from MosheZemah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amit-hanoch @hadasfa