amitha/fix/text-field-focus-animation-in-dialog #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit-hanoch
changed the title
orrgottlieb
requested changes
Nov 15, 2021
| @@ -104,6 +105,12 @@ const TextField = forwardRef( | |||
| elementType: "div" | |||
| }); | |||
|
|
|||
| useEffect(() => { | |||
| if (inputRef.current && autoFocus) { | |||
There was a problem hiding this comment.
add cancelAnimationFrame on the return function of the useEffect please
There was a problem hiding this comment.
@orrgottlieb found that i missed combo aswell please look there too :)
orrgottlieb
approved these changes
Nov 15, 2021
orrgottlieb
deleted the
amitha/fix/text-field-focus-animation-in-dialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autofocus in dialog and scrolling to the bottom of the screen the screen "jumps" because the focus collides with the scroll to, adding requestAnimationFrame is the solution.
Read about it a little bit and a lot of UI libraries like material-ui use setTimeout 0 to solve this issue and it's pretty common so I think we need to make sure all .focus() to happen with request animation frame from now on.
Updating existing component
Basic
Style
Storybook
Tests