Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix links story controls, add leanylabs as contributors and add few description to props #438

Merged
merged 5 commits into from
Jan 9, 2022
Merged

fix links story controls, add leanylabs as contributors and add few description to props #438

merged 5 commits into from
Jan 9, 2022

Conversation

hadasfa
Copy link
Contributor

@hadasfa hadasfa commented Jan 9, 2022

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

@hadasfa hadasfa changed the title Fix minor story bugs and some descriptions fix links story controls, add leanylabs as contributors and add few description to props Jan 9, 2022
hadasfa
hadasfa commented Jan 9, 2022
View reviewed changes
src/components/Link/Link.jsx
Link.position = ICON_POSITION;
Link.target = LINK_TARGET;

Link.iconPositions = ICON_POSITION;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because our new convention for enums is the name of the field in plural

@hadasfa hadasfa merged commit c04f4cc into master Jan 9, 2022
@hadasfa hadasfa deleted the storybook/hadas/link branch January 9, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orrgottlieb orrgottlieb orrgottlieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadasfa @orrgottlieb