Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icon button export #448

Merged
merged 1 commit into from
Jan 11, 2022
Merged

icon button export #448

merged 1 commit into from
Jan 11, 2022

Conversation

RonNachmany
Copy link
Contributor

@RonNachmany RonNachmany commented Jan 11, 2022 •
edited
Loading

export IconButton

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

@RonNachmany RonNachmany self-assigned this Jan 11, 2022
@orrgottlieb orrgottlieb merged commit e84d356 into master Jan 11, 2022
@orrgottlieb orrgottlieb deleted the icon-button-export branch January 11, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orrgottlieb orrgottlieb orrgottlieb approved these changes

@hadasfa hadasfa Awaiting requested review from hadasfa

Assignees

@RonNachmany RonNachmany

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RonNachmany @orrgottlieb