Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon button export #453

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Fix icon button export #453

merged 1 commit into from
Jan 12, 2022

Conversation

hadasfa
Copy link
Contributor

@hadasfa hadasfa commented Jan 12, 2022

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

@hadasfa hadasfa changed the title fix icon button expose Fix icon butto export Jan 12, 2022
@hadasfa hadasfa changed the title Fix icon butto export Fix icon button export Jan 12, 2022
@hadasfa hadasfa merged commit 820515a into master Jan 12, 2022
@hadasfa hadasfa deleted the fix/hadas/icon-button-fix branch January 12, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orrgottlieb orrgottlieb orrgottlieb approved these changes

Assignees
No one assigned
Labels
PR: Bugfix 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadasfa @orrgottlieb