Feature/hadas/flex #456
Feature/hadas/flex #456
Conversation
…to feature/hadas/flex � Conflicts: � src/components/index.js
|
|
||
| exports[`Flex renders correctly Horizontal display with children 1`] = ` | ||
| <div | ||
| className="" |
There was a problem hiding this comment.
for some reason it does not add the class names to the test... what should I do?
There was a problem hiding this comment.
@hadasfa where did you try the add a test with className
hadasfa
requested review from
orrgottlieb
and removed request for
orrgottlieb
| @@ -74,7 +74,11 @@ addParameters({ | |||
| "*", | |||
| "Accessibility", | |||
| "Hooks" | |||
| ] | |||
| ], | |||
| includeName: false, | |||
There was a problem hiding this comment.
@hadasfa can we upgrade the version of Storybook (it might solve it)
There was a problem hiding this comment.
we currently in very advanced alpha version. I can try to update to the most recent alpha version (we are few patches behind), that's ok?
There was a problem hiding this comment.
we can upgrade but could be for a different PR
|
|
||
| exports[`Flex renders correctly Horizontal display with children 1`] = ` | ||
| <div | ||
| className="" |
There was a problem hiding this comment.
@hadasfa where did you try the add a test with className
| @@ -74,7 +74,11 @@ addParameters({ | |||
| "*", | |||
| "Accessibility", | |||
| "Hooks" | |||
| ] | |||
| ], | |||
| includeName: false, | |||
There was a problem hiding this comment.
we can upgrade but could be for a different PR
| ({ className, id, elementType, direction, wrap, children, justify, align, gap, onClick, style }, ref) => { | ||
| const componentRef = useRef(null); | ||
| const mergedRef = useMergeRefs({ refs: [ref, componentRef] }); | ||
| const overrideStyle = useMemo(() => ({ ...style, gap: `${gap}px` }), [style, gap]); |
There was a problem hiding this comment.
@hadasfa what happen if i don't pass any gap value?
| const componentRef = useRef(null); | ||
| const mergedRef = useMergeRefs({ refs: [ref, componentRef] }); | ||
| const overrideStyle = useMemo(() => ({ ...style, gap: `${gap}px` }), [style, gap]); | ||
| const Element = onClick ? Clickable : elementType; |
Basic
npm run plop) to create a new component.PropTypes.Style
NewComponent.modules.scssfile inside of theNewComponentfolder.Storybook
/src/NewComponent/__stories__/NewComponent.stories.jsfile.Tests