Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace typography source to monday-ui-style font variables #521

Merged
merged 9 commits into from
Feb 8, 2022

Conversation

hadasfa
Copy link
Contributor

@hadasfa hadasfa commented Feb 8, 2022

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

@hadasfa hadasfa changed the title Css/hadas/typography Replace typography source to monday-ui-style font variables Feb 8, 2022
@hadasfa hadasfa merged commit cdbbb9b into master Feb 8, 2022
@hadasfa hadasfa deleted the css/hadas/typography branch February 8, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant