tooltip: removing border from tooltip arrow + adding themes to storybook #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etaylib
changed the title
laviomri
approved these changes
Feb 15, 2022
|
|
||
| Tooltip’s arrow can appear from top, bottom, left or right. | ||
|
|
||
| <Canvas> |
There was a problem hiding this comment.
CC @hadasfa WDYT about the following implementation?
<Canvas>
<Story name="Themes">
{Object.values(Tooltip.themes).map(theme => (
<div className="monday-storybook-tooltip_top" key={theme}>
<Tooltip
modifiers={modifiers}
content={capitalize(theme)}
shouldShowOnMount
position={Tooltip.positions.BOTTOM}
animationType="expand"
theme={theme}
>
<div/>
</Tooltip>
</div>
))}
</Story>
</Canvas>
It's shorter , and will automatically support new themes. However, the code snippet doesn't look too good:
I think it may be worth it, since this example will be used mainly to visually see all the themes, and not as a code reference. WDYT?
There was a problem hiding this comment.
just aligned with the others..will change
hadasfa
reviewed
Feb 15, 2022
| @@ -5,7 +5,8 @@ export const TOOLTIP_THEMES = { | |||
| Share: "share", | |||
| Private: "private", | |||
| Surface: "surface", | |||
| Primary: "primary" | |||
| Primary: "primary", | |||
| White: "white" | |||
There was a problem hiding this comment.
why the new name include the explicit color in its name? we always trying to choose names according to usage and not to explicit color.
There was a problem hiding this comment.
let's try to find a naming which indicate its usage purpose?
hadasfa
reviewed
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing the border from the tooltip's arrow as it added some weird border around it.
from
to
adding tooltip themes to storybook
exposing white theme