Fix tabs list bug - visible focus displayed when clicking out side and then clicking on one tab #537
Conversation
…to storybook/hadas/icon-button-dropdown � Conflicts: � src/components/Dropdown/__stories__/dropdown.stories.mdx
…to storybook/hadas/icon-button-dropdown
…to bug/hadas/tabs-focus � Conflicts: � src/components/IconButton/__stories__/IconButton.stories.mdx
| @@ -57,7 +57,7 @@ | |||
| } | |||
|
|
|||
| &.tab-focus-visible-inset { | |||
| @include focus-style-inset(3px, 3px); | |||
| @include focus-style-css-inset(3px, 3px); | |||
There was a problem hiding this comment.
the other mixin depend on using focus-visible class name which had different purpose (we inject it when we do real focus for old browsers support)
| setFocusTab(-1); | ||
| } | ||
| const getItemByIndex = useCallback(index => children[index], [children]); | ||
| const disabledIndexes = useMemo(() => Array.from(disabledTabIds), [disabledTabIds]); |
There was a problem hiding this comment.
I'm probably missing something, but shouldn't disabledTabIds just be called disabledTabIndexes? what's the difference here between an id and an index?
There was a problem hiding this comment.
the ids are index but saving in a set object which not support by the hook.
|
|
||
| const keyboardContext = useContext(GridKeyboardNavigationContext); | ||
|
|
||
| const onArrowNavigation = direction => { | ||
| setIsUsingKeyboardNav(true); | ||
| isUsingKeyboardNav.current = true; |
There was a problem hiding this comment.
at first I change it to ref because I wanted to add some events and I was afraid from changing react state and renders side effects, but then I saw that there no need to add events.
I keep it as ref because it save some not needed renders but I can undo this change
…to bug/hadas/tabs-focus � Conflicts: � src/components/Tabs/TabList/TabList.jsx
hadasfa
changed the title
hadasfa
changed the title
No description provided.