Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/hadas/checkbox ref #578

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Feature/hadas/checkbox ref #578

merged 4 commits into from
Mar 9, 2022

Conversation

hadasfa
Copy link
Contributor

@hadasfa hadasfa commented Mar 9, 2022

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

@hadasfa hadasfa added the feature label Mar 9, 2022
@hadasfa hadasfa requested review from orrgottlieb, MosheZemah, laviomri, sahariko and niksa-monday and removed request for orrgottlieb March 9, 2022 11:29
@hadasfa hadasfa merged commit 3b60a66 into master Mar 9, 2022
@hadasfa hadasfa deleted the feature/hadas/checkbox-ref branch March 9, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laviomri laviomri laviomri approved these changes

@MosheZemah MosheZemah Awaiting requested review from MosheZemah

@sahariko sahariko Awaiting requested review from sahariko

@niksa-monday niksa-monday Awaiting requested review from niksa-monday

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadasfa @laviomri