Fix radiobutton check issue #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadasfa
reviewed
Mar 15, 2022
| @@ -53,7 +46,7 @@ const RadioButton = forwardRef( | |||
| value={value} | |||
| name={name} | |||
| disabled={disabled} | |||
| {...checkedProps} | |||
| defaultChecked={checked || defaultChecked} | |||
There was a problem hiding this comment.
but checked prop is for controlled state. it's means that we want that when clicking on the radiobutton it's state will not changed (only if we changed it by our prop) - and not changed if we click once / twice.
hadasfa
reviewed
Mar 15, 2022
hadasfa
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with radio button needed to be clicked twice