# ay11 Foundation page Corrections: Update image sizes, add up next section #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection * Update images to 1000px width to align with layout width. * Add "up next" section with color, typography and hidden_text stories
3dyonic
changed the title
MosheZemah
approved these changes
Mar 23, 2022
|
approved design review. |
hadasfa
reviewed
Mar 29, 2022
| @@ -36,7 +37,8 @@ Web Accessibility is based on guidelines published by The World Wide Web Consort | |||
|
|
|||
| [WCAG Quick Reference](https://www.w3.org/WAI/WCAG21/quickref/?currentsidebar=%23col_customize#principle1) | |||
|
|
|||
| <Tip title="Get our Accessibility checklist"><a href={accessibilityCheckList} target="_blank">Download</a> our accessibility checklist file.</Tip> | |||
| <Tip title="Get our Accessibility checklist"><a href={accessibilityCheckList} target="_blank">Download</a> our | |||
There was a problem hiding this comment.
why not use here our link component (for storybook, not the one which belong to our design system)
There was a problem hiding this comment.
i was not aware of it.
hadasfa
approved these changes
Mar 29, 2022
…to fix/yonatanari/Ay11foundation-page-corrections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/245345663/pulses/2449052769)
Basic
npm run plop) to create a new component.PropTypes.Style
NewComponent.modules.scssfile inside of theNewComponentfolder.Storybook
/src/NewComponent/__stories__/NewComponent.stories.jsfile.Tests