test(Slider): add interaction tests for Slider component #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
niksa-monday
commented
Mar 29, 2022
•
niksa-monday
commented
- add first (initial) portion of interaction tests for Slider components
- delete irrelevant unit tests (tests replaced by interaction tests)
- add test for Decrease/Increase value by mouse click on Track/Rail - connect interaction tests to Story
- remove Non-ranged Slider Mouse Events unit tests it replaced by more relevant interaction tests - minor code conventions (lint) refactoring
- remove replace non range slider mouse events tests
laviomri
reviewed
Mar 29, 2022
laviomri
reviewed
Mar 29, 2022
laviomri
approved these changes
Mar 29, 2022
- change delay to waiting for - remove "visual" delay to constant - according to review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.