feat(accordion): add data-testid, improve ids, add interaction tests #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add data-testid - reformat component
- remove redundant const
- ExpandCollapse component have to get prop id for correct A11y (aria-controls) - AccordionItem now getting id on base of Accordion-Id and Index - If Accordion-Id not specified we are taking default COMPONENT_ID
- add interactions tests - connect tests to storybook - minor fix: remove unused import
- data-testid - ids improvements
laviomri
approved these changes
Mar 31, 2022
src/components/Accordion/Accordion/__tests__/accordion.interactions.js
Outdated
Show resolved
Hide resolved
- add additional expectation - after switch to another item: aria-expanded of the first item is false - according to review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add data-testid (reformat component)
Minor code conventions (lint) refactoring (remove redundant const)
Improve AccordionItem/ExpandCollapse ids
for correct A11y (aria-controls)
Add interaction tests for single-active mode