Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix icon size for small button #630

Merged
merged 2 commits into from
Apr 11, 2022
Merged

fix icon size for small button #630

merged 2 commits into from
Apr 11, 2022

Conversation

liatmaor
Copy link
Contributor

@liatmaor liatmaor commented Apr 7, 2022

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

https://monday.monday.com/boards/1812339248/pulses/2521169505

@liatmaor liatmaor requested a review from hadasfa April 7, 2022 13:17
@liatmaor liatmaor self-assigned this Apr 7, 2022
@liatmaor liatmaor merged commit 50c8a05 into master Apr 11, 2022
@liatmaor liatmaor deleted the fix/liat/icon-for-small-button branch April 11, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadasfa hadasfa hadasfa approved these changes

Assignees

@liatmaor liatmaor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liatmaor @hadasfa