Fix minor craft bugs (button disabled cursor and chip close button appearance) & stories & add data test id prop to chip, button, icon button #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadasfa
commented
Apr 11, 2022
hadasfa
commented
Apr 11, 2022
| @@ -106,15 +107,15 @@ const Chips = forwardRef( | |||
| /> | |||
| ) : null} | |||
| {hasCloseButton && ( | |||
| <Icon | |||
| aria-label={`Remove ${label}`} | |||
| <IconButton | |||
There was a problem hiding this comment.
fix bug - craft of close chip button
added 3 commits
April 11, 2022 17:54
…to comp-review/hadas/chips
added 2 commits
April 12, 2022 11:45
hadasfa
changed the title
hadasfa
changed the title
MosheZemah
approved these changes
Apr 12, 2022
src/components/Chips/Chips.jsx
Outdated
| @@ -28,10 +31,16 @@ const Chips = forwardRef( | |||
| onDelete, | |||
| onMouseDown, | |||
| noAnimation, | |||
| "data-testid": dataTestId | |||
| dataTestId, | |||
| "data-testid": deprecatedDataTestId | |||
There was a problem hiding this comment.
not needed - just remove it - it was for internal use
src/components/Chips/Chips.jsx
Outdated
| }, | ||
| ref | ||
| ) => { | ||
| const overrideDataTestId = backwardCompatibilityForProperties( |
There was a problem hiding this comment.
not need to backward compatibly this atribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stories and minor craft bugs in: toggle, button, chips