Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI][Restore wallet] 'Create wallet' stays disabled until monero-wallet-gui is closed #4341

Open
b4n6-b4n6 opened this issue Aug 22, 2024 · 5 comments · May be fixed by #4346 or #4351
Open

[GUI][Restore wallet] 'Create wallet' stays disabled until monero-wallet-gui is closed #4341

b4n6-b4n6 opened this issue Aug 22, 2024 · 5 comments · May be fixed by #4346 or #4351

Comments

@b4n6-b4n6
Copy link

Kindly observe video @ 00:37 where 'Create wallet' button stays disabled even though mnemonic seed has been corrected
restore-bug-2.webm

@nahuhh
Copy link

nahuhh commented Aug 23, 2024

Confirmed

@plowsof
Copy link
Contributor

plowsof commented Aug 23, 2024

newlines / extra whitespaces can be stripped from the users seed to pass verification and sent to the wallet api. there would be concerns with merging this as we are modifying the structure of the users seed and potentially creating a different wallet. there is always 1 person who will enter words 1, 6, 11, 16, 21 on the first line lol

to avoid that concern, the restore wallet from seed screen would be the same window as the seed preview with numbers next to each word.

@nahuhh
Copy link

nahuhh commented Aug 23, 2024

The whitepaces and lines seem to be stripped properly

the problem is that the "create wallet" button remains greyed out indefinitely (until restarting the wallet)

@b4n6-b4n6
Copy link
Author

b4n6-b4n6 commented Aug 23, 2024

newlines / extra whitespaces can be stripped from the users seed to pass verification and sent to the wallet api. there would be concerns with merging this as we are modifying the structure of the users seed and potentially creating a different wallet. there is always 1 person who will enter words 1, 6, 11, 16, 21 on the first line lol

to avoid that concern, the restore wallet from seed screen would be the same window as the seed preview with numbers next to each word.

Kindly
Whitespace in seed is not relevaant to this issue

the problem is that the "create wallet" button remains greyed out indefinitely (until restarting the monero-wallet-gui)

@b4n6-b4n6
Copy link
Author

Fix PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants