Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-3247): bump spec tests and fix up DBRef handling #443

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

addaleax
Copy link
Contributor

Description

I wanted to bump the spec tests for NODE-3094, turns out there’s
nothing to do there, but NODE-3247 breaks the tests, so I’ve made
changes that align the handling with the spec here.

I wanted to bump the spec tests for NODE-3094, turns out there’s
nothing to do there, but NODE-3247 breaks the tests, so I’ve made
changes that align the handling with the spec here.
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 24, 2021
@dariakp dariakp self-requested a review June 24, 2021 19:24
@dariakp dariakp requested a review from nbbeeken June 25, 2021 18:46
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken requested review from durran and emadum June 25, 2021 18:49
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 25, 2021
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit f5d984d into mongodb:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants